Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

[Andrew Morton]

On Fri, 1 Jun 2007 21:01:09 -0700 (PDT) Christoph Lameter <clameter@xxxxxxx> wrote:

> On Fri, 1 Jun 2007, Andrew Morton wrote:
> 
> > > On Fri, 1 Jun 2007 18:37:46 -0700 (PDT) Christoph Lameter <clameter@xxxxxxx> wrote:
> > >
> > > +#define ZERO_SIZE_PTR ((void *)16)
> > 
> > Jeremy's point was a good one.  The kernel _does_ use address-comparison
> > to determine object-inequality in an unknown but non-zero number of places.
> > 
> > It is of course unlikely that this will occur in conjunction with zero-sized
> > objects, but who knows?
> 
> The zero sized objects are always the same and have the same content of 
> nothingness. So the kernel would find that they are the same which they 
> indeed are. Why could this be a problem?

They are different instances which happen to have the same length (zero).

But the code will incorrectly decide that they are the same instance.  It
might cause refcounting or accounting errors, for example.  I don't know - the
kernel's a big place.

I agree the risk is low, but if something _does_ blow up, it will do so subtly.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/