2.6.22-rc3-mm1: Xen compile error with X86_CMPXCHG=n

From: Adrian Bunk
Date: Sat Jun 02 2007 - 09:57:23 EST


I'm getting the following compile error in 2.6.22-rc3-mm1 with
CONFIG_X86_CMPXCHG=n (with -Werror-implicit-function-declaration -
otherwise it would be a link error):

<-- snip -->

...
CC drivers/xen/grant-table.o
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc3-mm1/drivers/xen/grant-table.c: In function âgnttab_end_foreign_access_refâ:
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc3-mm1/drivers/xen/grant-table.c:203: error: implicit declaration of function âsync_cmpxchgâ
make[3]: *** [drivers/xen/grant-table.o] Error 1

<-- snip -->

Adding a dependency of XEN on X86_CMPXCHG should not be a problem and
not prevent any reasonable real-life usage.

But what worries me is that a seemingly architecture independent
driver uses a function only available in some configurations.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/