Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy

[Chuck Ebbert]

On 06/04/2007 10:21 PM, Masatake YAMATO wrote:
> diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
> index 30175c7..5e05311 100644
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -249,7 +249,7 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
>  	while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
>  		udelay(10);
>  
> -	if (!retries)
> +	if (retries < 0)

	if (stat & BUSY_STAT)

>  		printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
>  
>  	return stat;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/