Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP

[Jared Hulbert]

> On Wed, Jun 06, 2007 at 09:07:16AM -0700, Jared Hulbert wrote:
> > I estimate something on the order 5-10 million Linux phones use
> > something similar to these patches.  I wonder if there are that many
> > provable users of of the simple cramfs.  This is where the community
> > has taken cramfs.
>
> This is what a community disjoint to mainline development has hacked
> cramfs in their trees into.  Not a good rationale.  This whole
> "but we've always done it" attitute is a little annoying, really.

It is that disjointedness we are trying to address.

> FYI: Cartsten had an xip fs for s390 aswell, and that evolved into
> the filemap.c bits after a lot of rework an quite a few round of
> review.

Right.  So now we leverage this filemap_xip.c in cramfs.  Why is this a problem?

> > Nevertheless, I understand your point.  I wrote AXFS in part because
> > the hacks required to do XIP on cramfs where ugly, hacky, and complex.
>
> I can't find a reference to AXFS anywhere in this thread.

No, it's not here.  There's a year old thread referencing it.

> > > Please
> > >use something like the existing ext2 xip mode instead of add support
> > >to romfs using the generic filemap methods.
> >
> > What??  You mean like use xip_file_mmap() and implement
> > get_xip_page()?  Did you read my latest patch?
>
> Yes.  This is the highlevel way to go, just please don't hack it into
> cramfs.

Right, so this latest patch _does_ implement get_xip_page() and
xip_file_mmap().  Why not hack it into cramfs?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/