Re: [v4l-dvb-maintainer] drivers/media/dvb/b2c2/flexcop-dma.c usesPCI DMA API

[Michael Krufky]

Mauro Carvalho Chehab wrote:
> Hi Geert,
>
> Em Qua, 2007-06-06 Ãs 21:11 +0200, Geert Uytterhoeven escreveu:
>   
>> 	Hi,
>>
>> drivers/media/dvb/b2c2/flexcop-dma.c uses the PCI DMA API, but DVB_B2C2_FLEXCOP
>> doesn't depend on PCI, causing the following problem on PCI-less systems:
>>
>> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
>> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
>>
>> Apparently this is the flexcop DMA core, which is used by both
>> DVB_B2C2_FLEXCOP_PCI and DVB_B2C2_FLEXCOP_USB.
>>
>> DVB_B2C2_FLEXCOP_PCI depends on PCI.
>> DVB_B2C2_FLEXCOP_USB depends on USB.
>>     
>
> Thanks for pointing us about this issue. While the usage of the generic
> dma is the better way, a simple fix can be applied by simply moving
> flexcop-dma to b2c2-flexcop-pci (currently, only the last uses the DMA
> stuff). I've committed such patch. It is available at:
>
> http://linuxtv.org/hg/v4l-dvb/rev/c314ec17335a
>   

Mauro,

It appears that your change has caused the following build warning:

WARNING: "b2c2_flexcop_debug"
[/home/mk/v4l-dvb-master/v4l/b2c2-flexcop-pci.ko] undefined!

Regards,

Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/