Re: beeping patch for debugging acpi sleep

From: Rafael J. Wysocki
Date: Wed Jun 13 2007 - 08:34:47 EST


On Wednesday, 13 June 2007 14:28, Pavel Machek wrote:
> Hi!
>
> > > > Ok. I'll take Pavel's silence as agreement too. I'll be a little slow
> > > > (as usual, nowadays!), but will try to get it done next week. I think I
> > > > can in clear conscience do it on Redhat time if I don't manage it
> > > > beforehand.
> > >
> > > Well, everyone wants it so what can I do... Stefan basically posted 3
> > > liner to do that, and that one will probably work... so just test it.
> >
> > As he admitted, it's a quick and dirty hack. I'd like to try something
> > nicer.
>
> Well, his hack + rename one variable and there's one very nice solution.
>
> > > Oh, and please keep the macro, so it can be moved around .S file for
> > > finding out where it crashes.
> >
> > Are there other points you'd like to nominate? It would defeat the logic
> > for implementing a nice interface if you still have to recompile your
> > kernel to test beeping in another place.
>
> Just before entering C would be another interesting point.

Well, x86_64 version would be nice to have too. ;-)

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/