Re: [PATCH 2/2] readahead: sanify file_ra_state names

From: Rusty Russell
Date: Fri Jun 15 2007 - 00:38:26 EST


On Thu, 2007-06-14 at 14:21 +0800, Fengguang Wu wrote:
> plain text document attachment (readahead-rename.patch)
> Rename some file_ra_state variables and remove some accessors.
>
> It results in much simpler code.
> Kudos to Rusty!
>
> Signed-off-by: Fengguang Wu <wfg@xxxxxxxxxxxxxxxx>

Needless to say, I'm now very satisfied with the new readahead code.

That's not to say there won't be corner cases where the old code did
better, but given the replacement's simplicity and Fengguang's positive
benchmark results I really like it.

Thanks for Fengguang for coding and pushing this!
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/