Re: [patch 05/26] Slab allocators: Cleanup zeroing allocations

From: Pekka Enberg
Date: Mon Jun 18 2007 - 16:16:50 EST


On 6/18/07, clameter@xxxxxxx <clameter@xxxxxxx> wrote:
+static inline void *kmem_cache_zalloc(struct kmem_cache *k, gfp_t flags)
+{
+ return kmem_cache_alloc(k, flags | __GFP_ZERO);
+}
+
+static inline void *__kzalloc(int size, gfp_t flags)
+{
+ return kmalloc(size, flags | __GFP_ZERO);
+}

Hmm, did you check kernel text size before and after this change?
Setting the __GFP_ZERO flag at every kzalloc call-site seems like a
bad idea.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/