Re: [PATCH 7/12] acpi: fix another compile warning
From: Ravikiran G Thirumalai
Date: Wed Jun 20 2007 - 14:26:07 EST
On Wed, Jun 20, 2007 at 09:36:30AM -0400, Len Brown wrote:
> On Wednesday 20 June 2007 04:49, Andreas Herrmann wrote:
> > On Tue, Jun 19, 2007 at 11:38:02PM -0400, Len Brown wrote:
> > > On Tuesday 19 June 2007 18:50, Andreas Herrmann wrote:
>
> I fear, however, that this patch defeats the purpose of
> b0bd35e622ffbda2c01dc67a0381c6a18817a29a -- which was to make selecting
> NUMA more user-friendly. So it might make more sense to simply revert that
> patch entirely.
>
> The underlying problem is that Kconfig doesn't support using select
> on targets which themselves have dependencies.
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
>
>
> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
> index 5ce9443..e9d7767 100644
> --- a/arch/x86_64/Kconfig
> +++ b/arch/x86_64/Kconfig
> @@ -364,9 +364,9 @@ config NODES_SHIFT
> config X86_64_ACPI_NUMA
> bool "ACPI NUMA detection"
> depends on NUMA
> - select ACPI
> + depends on ACPI
> select PCI
> - select ACPI_NUMA
> + depends on ACPI_NUMA
> default y
> help
> Enable ACPI SRAT based node topology detection.
> -
arch/x86_64/Kconfig:706:error: found recursive dependency: PCI -> ACPI ->
X86_64_ACPI_NUMA -> PCI
-> USB_ARCH_HAS_OHCI -> USB_ARCH_HAS_HCD -> MOUSE_APPLETOUCH -> USB ->
USB_SISUSBVGAmake[1]: *** [menuconfig] Error 1
I guess we have to change PCI to 'depends on' as well.
Else, select PM?
I am OK with either approach.
Thanks,
Kiran
Paper over 'select' inadequacies.
Signed-off-by: Ravikiran Thirumalai <kiran@xxxxxxxxxxxx>
Index: linux-2.6.22-rc5/arch/x86_64/Kconfig
===================================================================
--- linux-2.6.22-rc5.orig/arch/x86_64/Kconfig 2007-06-18 16:02:19.571323415 -0700
+++ linux-2.6.22-rc5/arch/x86_64/Kconfig 2007-06-20 11:34:29.845354250 -0700
@@ -366,6 +366,7 @@ config X86_64_ACPI_NUMA
depends on NUMA
select ACPI
select PCI
+ select PM
select ACPI_NUMA
default y
help
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/