Re: [patch 21/26] Slab defragmentation: support dentry defragmentation

From: Christoph Lameter
Date: Tue Jun 26 2007 - 14:23:42 EST


On Tue, 26 Jun 2007, Andrew Morton wrote:

> > + * objects.
> > + */
> > + abort = 1;
>
> It's unobvious why the entire shrink effort is abandoned if one busy dentry
> is encountered. Please flesh the comment out explaining this.

If one item is busy then we cannot reclaim the slab. So what would be the
use of continuing efforts. I thought I put that into the description? I
can put that into the code too.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/