[PATCH] Fix lguest w/ lockdep

From: Rusty Russell
Date: Thu Jun 28 2007 - 09:32:17 EST


On Wed, 2007-06-27 at 19:14 -0500, Matt Mackall wrote:
> lguest: unhandled trap 14 at 0xc01362f7 (0x0)
> Dump of assembler code for function __lock_acquire:

Thanks for the bug report Matt! I wonder if other
paravirt_disable_iospace users have the same issue...
===

Fix "lguest: unhandled trap 14 at 0xc013630f (0x0)" with CONFIG_LOCKDEP=y

paravirt_disable_iospace -> request_resource -> write_lock -> __lock_acquire()

lockdep_init() is already idempotent: simply call it before
paravirt_disable_iospace().

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

diff -r bea2b8147985 drivers/lguest/lguest.c
--- a/drivers/lguest/lguest.c Thu Jun 07 22:50:36 2007 +1000
+++ b/drivers/lguest/lguest.c Thu Jun 28 23:21:26 2007 +1000
@@ -593,6 +593,8 @@ __init void lguest_init(void *boot)

reserve_top_address(lguest_data.reserve_mem);

+ lockdep_init();
+
paravirt_disable_iospace();

cpu_detect(&new_cpu_data);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/