Re: [PATCH] Optional Beeping During Resume From Suspend To Ram.

From: Stefan Seyfried
Date: Fri Jun 29 2007 - 14:05:42 EST


On Fri, Jun 29, 2007 at 08:27:12AM +1000, Nigel Cunningham wrote:
> > Can we rename/reuse existing flag variable?
>
> Sorry, but I can't resist the opportunity to say "Send a patch!" :)
>
> Seriously, though, I'd prefer not to. If we rename that acpi video flags
> variable (I assume this is what you're thinking of), we only create cause for
> confusion. A variable should for debugging or for controlling quirks, not for
> both at the same time.

I agree. And video_flags is something totally different :-)
I just used that one in my ad-hoc hack (which actually was only to illustrate
the idea) because a) it was enough to show the intent and b) i did not know
how to do it better ;-)
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/