Re: [RFC] fsblock

From: Christoph Hellwig
Date: Sat Jun 30 2007 - 06:43:02 EST


On Sat, Jun 23, 2007 at 11:07:54PM -0400, Jeff Garzik wrote:
> >- In line with the above item, filesystem block allocation is performed
> > before a page is dirtied. In the buffer layer, mmap writes can dirty a
> > page with no backing blocks which is a problem if the filesystem is
> > ENOSPC (patches exist for buffer.c for this).
>
> This raises an eyebrow... The handling of ENOSPC prior to mmap write is
> more an ABI behavior, so I don't see how this can be fixed with internal
> changes, yet without changing behavior currently exported to userland
> (and thus affecting code based on such assumptions).

Not really, the current behaviour is a bug. And it's not actually buffer
layer specific - XFS now has a fix for that bug and it's generic enough
that everyone could use it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/