Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

[Chr]

On Wednesday, 4. July 2007, Thorsten Leemhuis wrote:
>
> Maybe Alan or someone from Intel can answer that and thus tell us how to
> move forward; it would be really nice to get the patch that started this
> thread (it got posted by Chuck again today) could go into 2.6.22, but I
> assume the time runs away...
>
Jeff is on holiday and Intel doesn't respond at all... 

So, if someone has a ICH5 or ICH7/7-R with a ATA133 captable HDD... could
you please try the following patch? (Of course, I don't know if it works,...
It may cause data loss, serve corruption, or damage your controller/hdd/pc,
so make backups and keep a first-aid kit handy!) 
  
> > On the other hand, we can leave it, because of a "off-by-one error" in ata_piix.c, 
> > do_pata_set_dmamode, line ~770:
> > [...]
> 

Thanks,
	Chr.

--- a/drivers/ata/ata_piix.c	2007-06-19 12:19:39.000000000 +0200
+++ b/drivers/ata/ata_piix.c	2007-07-05 22:11:52.000000000 +0200
@@ -767,8 +767,8 @@
 		 *	       except UDMA0 which is 00
 		 */
 		u_speed = min(2 - (udma & 1), udma);
-		if (udma == 5)
-			u_clock = 0x1000;	/* 100Mhz */
+		if (udma >= 5)
+			u_clock = 0x1000;	/* 133Mhz */
 		else if (udma > 2)
 			u_clock = 1;		/* 66Mhz */
 		else