Always zero test in arch/i386/pci/mmconfig-shared.c

From: Scott Ashcroft
Date: Tue Jul 10 2007 - 14:53:22 EST


I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is:

pci_mmcfg_config_num = 0;

...

if (name) {
printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n",
name, pci_mmcfg_config_num ? "with" : "without");
}

So it will always prints "without".

I'd make a patch but I'm not sure what this fix is. Just drop the test, the printk or make it say "which might possibly have"?

Cheers,
Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/