Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

[Sergei Shtylyov]

Hello.

Vitaly Bordug wrote:

> > > +
> > > +#ifdef CONFIG_MPC834x_ITX  

> >    Erm, isn't this stuff misplaced? Is this really SoC device? I
> > remember seeng this in the arch/ppc/ platform code before (in the
> > internal tree)...

> The point is to declare methods bsp, as mmio access may effectively vary (having bugs or intentionally) from platform to platform. All-in-one driver approach is nice but might be an issue to handle/maintain.

   You misunderstood. Why this was placed in fsl_soc.c and not in the proper 
platform code (as it was in the internal tree even)?

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/