Re: why does git perpetually complain about include/asm-blackfin/macros.h?

From: Sam Ravnborg
Date: Sat Jul 14 2007 - 03:44:57 EST


On Mon, Jul 02, 2007 at 10:37:28AM -0400, Jeff Garzik wrote:
> Alex Riesen wrote:
> >Do some of your branches miss the commit by which it was removed?
>
> git-clone followed by git-checkout master recreates the problem.
>
> But to answer your question directly, I rebase, so they absolutely do
> not miss any commits.
>
>
> >It is somewhat unclear what "reappear" means, though: do you mean
>
> Attempts to give you precise output to answer your question yielded a
> data point, the kernel's "make distclean" causes this:
>
> [jgarzik@pretzel linux-2.6]$ make distclean && git checkout master &&
> git diff HEAD
> D include/asm-blackfin/macros.h
> Switched to branch "master"
> diff --git a/include/asm-blackfin/macros.h b/include/asm-blackfin/macros.h
> deleted file mode 100644
> index e69de29..0000000
>
> [jgarzik@pretzel linux-2.6]$ git checkout -f
>
> [jgarzik@pretzel linux-2.6]$ make distclean && git checkout master &&
> git diff HEAD
> D include/asm-blackfin/macros.h
> Switched to branch "master"
> diff --git a/include/asm-blackfin/macros.h b/include/asm-blackfin/macros.h
> deleted file mode 100644
> index e69de29..0000000
>
> [jgarzik@pretzel linux-2.6]$ git checkout -f
>
> [jgarzik@pretzel linux-2.6]$ git checkout master && git diff
> HEADSwitched to branch "master"
>
> [jgarzik@pretzel linux-2.6]$ git checkout master && git diff HEAD
> Switched to branch "master"
>
> [jgarzik@pretzel linux-2.6]$
>
>
> So, not a git problem but a kernel Makefile problem. Sorry for the git
> noise.

distclean on purpose delete zero size files.
And the kernel tree shall not contain such files - if it does it is a bug.

So I do not see a 'problem' with the kernel makefile but instead a problem
with the kernel tree wich is about to be fixed.

Agree?

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/