Re: [patch 3/8] Text Edit Lock - i386

From: Christoph Hellwig
Date: Sat Jul 14 2007 - 12:18:44 EST


On Fri, Jul 13, 2007 at 09:21:36PM -0400, Mathieu Desnoyers wrote:
> +#ifdef CONFIG_DEBUG_RODATA
> +static int rodata_marked;
> +#endif

Maybe I'm missing something, but the rodata section should always stay
r/o, only text needs locking/unlocking, no?

Given that all code in this patch only operates on .text this seems fine,
but the variables/config options are grossly misnamed then. And actually
making rodata r/o doesn't seem like a pure debugging thing to me either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/