Re: [PATCH] remove PAGE_SIZE from headers_install

From: David Miller
Date: Sat Jul 14 2007 - 23:43:20 EST


From: "Albert Cahalan" <acahalan@xxxxxxxxx>
Date: Sat, 14 Jul 2007 22:48:57 -0400

> A real constant-value PAGE_SIZE is useful and doable.

It's bogus to use it. The kernel can get recompiled
to arbitrary page sizes on some architectures, so a constat
page size assumption cannot work.

> It's useful because a getpagesize() can't be used for numerous
> things, such as setting the size of an array.

Use dynamically allocated memory for the array then.

This isn't programming 101.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/