Re: [PATCH 3/10] sysfs: fix error handling in create_files()

From: Cornelia Huck
Date: Mon Jul 16 2007 - 11:29:45 EST


On Mon, 16 Jul 2007 22:52:30 +0900,
Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> Current error handling in create_files() attempts to remove
> all attributes passed by argument by remove_files(). But it should
> only remove the attributes that have been successfully added.

While this is certainly cleaner, a question out of curiousity: Does
this fix any problem you saw? sysfs_hash_and_remove() used to be safe
on non-existing attributes...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/