[PATCH][IPMI] Fix mem leak in try_init_dmi() code

From: Jesper Juhl
Date: Wed Jul 18 2007 - 19:01:45 EST


Hi there,

If we ever hit the "default:" case in the switch in try_init_dmi(),
then we'll leak the storage allocated with kzalloc() and assigned
to 'info'.

Note: patch has been compile tested only.

Please consider merging upstream :-)


Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
---

drivers/char/ipmi/ipmi_si_intf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c
b/drivers/char/ipmi/ipmi_si_intf.c
index 4edfdda..96d2f9e 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2050,6 +2050,7 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data
*ipmi_data)
info->si_type = SI_BT;
break;
default:
+ kfree(info);
return;
}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/