Re: Powerpc - Include pagemap.h in asm/powerpc/tlb.h

From: Kumar Gala
Date: Thu Jul 19 2007 - 18:46:01 EST



On Jul 19, 2007, at 4:30 PM, Andrew Morton wrote:

On Thu, 19 Jul 2007 16:04:38 -0500
Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:

Andrew,

Are you sending this to linus directly or should this go via paul and
me?


I queued it up for Paul. I can send it over to Linus today if we
have a
reason for that. It's just that I dont understand the patch: does
it fix
-mm-only breakage? Does it fix something which already got fixed,
or what?

I'm seeing the same breakage in my tree.

Oh, OK. Let's just merge it.

Hmm, depending on the config it goes away.

Lets hold off on this for a little while so understand exactly what's going on.

One might think "gee, it's trivial, just slam it in", but these nested
includes are often not-trivial and something else can explode as a
result.

I'll do a git-bisect and see if I can find the patch that causes this
breakage so we know what's going on.

eh, don't bother.

I think I'll poke around a little since it clearly has some config dependancy.

- k

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/