Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

From: Scott Wood
Date: Fri Jul 20 2007 - 12:53:17 EST


On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote:
> On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <vitb@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, 19 Jul 2007 23:23:37 -0700
> > Andrew Morton wrote:
> > > Shouldn't these be runtime options (ie: module parameters)?
> > >
> > I thought about it but this thing is more like the one that will never tend/required to change while\
> > configured.. Will add if you see it appropriate though.
>
> 99% of users don't compile their own kernels: their vendor will have to
> make this decision for them, and it sounds like any decision which they
> make will be wrong for some of their users?

This is mostly of use on embedded hardware where the kernel will be
rebuilt by someone who knows the hardware... That said, I don't see why
it needs to be configured at all. Couldn't it use an idr table instead?

-Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/