Re: build fix for x86_64...

From: H. Peter Anvin
Date: Fri Jul 20 2007 - 13:04:33 EST


Luck, Tony wrote:
>
> Which is better. But if we unconditionally set this CONFIG variable, then the
> code in fs/quota.c will have to read:
>
> #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT)
>
> We can keep it simpler if the Kconfig file does the conditional for us:
>
> config COMPAT_FOR_U64_ALIGNMENT
> def_bool y
> depends on COMPAT
>

No, that would be bad. If compat_u64 is used to carry 32-bit ABIs
forward into 64-bit space without needing compatibility hacks, then this
would actually introduce ABI incompatibilities depending on CONFIG_COMPAT!

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/