Re: [PATCH] Fix fbcon - 'map_override' defined but not used warning

From: Antonino A. Daplas
Date: Mon Jul 23 2007 - 02:18:59 EST


On Sun, 2007-07-22 at 18:23 +0200, Gabriel C wrote:
> Hi,
>
> I got this warning on current git:
>
> ...
>
> drivers/video/console/fbcon.c:130: warning: 'map_override' defined but not used
>
> ...
>
> Signed-off-by: Gabriel Craciunescu <nix.or.die@xxxxxxxxxxxxxx>
>
> ---
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index decfdc8..60a14de 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -127,7 +127,9 @@ static int last_fb_vc = MAX_NR_CONSOLES - 1;
> static int fbcon_is_default = 1;
> static int fbcon_has_exited;
> static int primary_device = -1;
> +#ifndef MODULE

Disrecard my other comment. This should be

#ifdef CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY

> static int map_override;
> +#endif
>
> /* font data */
> static char fontname[40];

Tony

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/