Re: [patch 1/3] ps3: Disk Storage Driver

[Andreas Schwab]

Jeff Garzik <jeff@xxxxxxxxxx> writes:

> Andy Whitcroft wrote:
>> Andrew Morton wrote:
>> 
>>>> +	start_sector = req->sector*priv->blocking_factor;
>>>> +	sectors = req->nr_sectors*priv->blocking_factor;
>>> s/*/ * /.  checkpatch missed this.
>> 
>> Ok, this is something we need to decide on.  Currently we only ask for
>> consistent spacing on all the mathematic operators.  This is mostly as
>> we do see a large number of non-spaced uses in defines and the like.
>> 
>> I am happy to expand these tests so they are always spaced on both sides
>> style if that is the preference.
>
> That is most definitely the preference:  spaces surround operators.
                                                          ^binary

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/