Re: [patch] fix the softlockup watchdog to actually work

From: Ingo Molnar
Date: Wed Jul 25 2007 - 04:56:18 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> > Still isn't working. I'm getting random meaningless softlockup
> > trippings coming out for no apparent reason.
>
> hm, you still havent applied the other 4 patches i sent:
>
> softlockup-fix.patch
>
> softlockup-add-irq-regs-h.patch
> softlockup-better-printout.patch
> softlockup-cleanups.patch
> softlockup-use-cpu-clock.patch
>
> they are all necessary.
>
> softlockup-use-cpu-clock.patch could easily solve the present problem
> you have: as i pointed it out it is _wrong_ to use sched_clock(),
> because sched_clock() is not a reliable clocksource. Especially on
> your VAIO.

note: the cpu_clock() API is in v2.6.23-rc1 already so the above patches
work fine as-is.

[ for -stable, my other patch should be used that restores jiffies use
in softirq.c. ]

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/