Re: [-mm patch] one e1000 driver should be enough for everyone

From: Jeff Garzik
Date: Wed Jul 25 2007 - 11:05:23 EST


Adrian Bunk wrote:
I found the discussion, and Christoph's e1000e sounds like the best name ("new" doesn't say whether it's a new driver for old hardware or a driver for new hardware).

Yeah, I think "e1000new" is a lame name.

e1000e is good, or even e1001e if we wanted even more symmetry :)


No problem for me, but this obviously implies that global code in the new driver has to be renamed.

Yes. A global namespace is a global namespace.


And please ensure that they will always support distinct PCI IDs, or there will be the following common pattern if both drivers support
a card:

IIRC I think Auke said there is some minor PCI ID overlap that must be addressed in the transition. Disappointing and it raises transition issues, but that's the way the split falls out naturally AFAICS.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/