Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

From: Bjorn Helgaas
Date: Wed Jul 25 2007 - 23:34:40 EST


On Wednesday 25 July 2007 08:21:06 pm Shaohua Li wrote:
> On Wed, 2007-07-25 at 17:37 -0700, Yinghai Lu wrote:
> > On 7/25/07, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
> > > Yinghai, you mentioned the same issue on boxes with multiple root
> > > bridges. Any chance you could try this out there as well?
> > >
> > it doesn't solve pci_root_bus reverse problem.
> >
> > is that too late for PNP0A03?
> >
> > I wonder if we need to modify acpi_device_register to sort them.
> The pci root driver is an acpi driver not a pnp driver, so Bjorn's patch
> will not work.

Right, I forgot that the PCI root driver is an ACPI driver.

This is a longer-term idea, but the way I'd like to solve this is
by converting ACPI drivers into PNP drivers. Then the PNPACPI sort
would work for all of them. PNP would provide a hook to retrieve
the ACPI handle corresponding to a PNP device.

> Maybe the ACPI core (ACPICA) should do the sort?

I thought about that, but I didn't see a nice way to do it. The
current namespace interfaces like acpi_get_devices() are walk-
oriented -- they call a callback function for every node that
meets some criteria. Sorting requires some sort of buffer so
you can look at all the matching nodes before returning any of
them.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/