Re: LinuxPPS & spinlocks

[Chris Friesen]

Rodolfo Giometti wrote:

> What do you mean? Did you find an error into my patch? :-o
>
> Functions pps_event() and
> pps_register_source()/pps_unregister_source() take accesso to shared
> data, that's why I used spinlocks.

My point is that the lock should be used to protect specific data. 
Thus, it would be more correct to say, "spinlock foo is taken because 
pps_register_source() accesses variable bar".

That way, if someone else wants to access "bar", they know that they 
need to take lock "foo".

Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/