Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULLdereferences

From: Marcel Holtmann
Date: Sun Jul 29 2007 - 12:47:25 EST


Hi Eugene,

> Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all
> the possible NULL dereferences. Besides hci_uart_close(), we also need to
> make sure that hdev is valid before calling hci_{unregister,free}_dev().

I don't see any issue. Without HCI_UART_PROTO_SET, the hdev will never
be registered. So no need to protect it twice.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/