Re: [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers.

From: Christian Borntraeger
Date: Tue Jul 31 2007 - 10:07:11 EST


Am Dienstag, 31. Juli 2007 schrieb jack@xxxxxxxxxxxxxxxxxxxxxxx:
> - a = (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + 8,
GFP_KERNEL);
> + a = kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL);

NAK.
Same as in some other patches.
"void *" -> "ulong" is not auto casted and will give you a "warning:
assignment makes integer from pointer without a cast".

Christian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/