RE: [PATCH] flush icache before set_pte take6. [3/4] add montecito brand name

From: Luck, Tony
Date: Tue Jul 31 2007 - 12:40:35 EST


+ } else if (family == 0x20)
+ memcpy(brand, "Montecito", 10);

NAK.

We don't really have names for the different cpu families. "Montecito"
is definitely not the right string to apply here (Montvale will also
have family == 0x20). The old McKinley/Madison strings are intended
to provide some information for old processors where PAL did not
support PAL_BRAND_INFO. All new cpus (from Montecito onward) will
support this PAL call, so there should be no need to add more code to
make names out of [family,model] tuples.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/