[PATCH] argv_split: allow argv_split to handle NULL pointer in argcp parameter gracefully

From: Neil Horman
Date: Tue Jul 31 2007 - 12:47:15 EST


As Jeremy and I had discussed in a previous thread, it would be nice if the
argv_split library function could gracefully handle a NULL pointer in the argcp
parameter, so as to allow functions using it that did not care about the value
of argc to not have to declare a useless variable. This patch accomplishes
that. Tested by me, with successful results.

Thanks & Regards
Neil

Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>


argv_split.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


diff --git a/lib/argv_split.c b/lib/argv_split.c
index 4096ed4..fad6ce4 100644
--- a/lib/argv_split.c
+++ b/lib/argv_split.c
@@ -75,7 +75,9 @@ char **argv_split(gfp_t gfp, const char *str, int *argcp)
if (argv == NULL)
goto out;

- *argcp = argc;
+ if (argcp)
+ *argcp = argc;
+
argvp = argv;

while (*str) {
--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@xxxxxxxxxxxxx
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/