Re: [PATCH] update checkpatch.pl to version 0.08

From: Andy Whitcroft
Date: Fri Aug 03 2007 - 08:38:10 EST


Jan Engelhardt wrote:
> On Jul 23 2007 16:36, Kok, Auke wrote:
>> this somehow seems to match something completely non-related (a function
>> pointer declaration case):
>>
>> ERROR: no space between function name and open parenthesis '('
>> #7278: FILE: drivers/net/e1000e/hw.h:434:
>> + bool (*check_mng_mode)(struct e1000_hw *);
>>
>> even if I put a space between ")(", it still complains.
>
> [assumed] majority of kernel code uses ")(" instead of ")\s+(",
> so the warning seems bogus. And it even gets nitpicky.

No that is just a false positive. Those are meant to be detected, its
just that bool wasn't listed as a type.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/