[PATCH v2] Off-by-one in /sys/module/*/refcnt

From: Alexey Dobriyan
Date: Mon Aug 06 2007 - 15:48:01 EST


sysfs internals were changed to not pin module in question.

Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
---

kernel/module.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/module.c
+++ b/kernel/module.c
@@ -784,8 +784,7 @@ EXPORT_SYMBOL_GPL(symbol_put_addr);
static ssize_t show_refcnt(struct module_attribute *mattr,
struct module *mod, char *buffer)
{
- /* sysfs holds a reference */
- return sprintf(buffer, "%u\n", module_refcount(mod)-1);
+ return sprintf(buffer, "%u\n", module_refcount(mod));
}

static struct module_attribute refcnt = {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/