Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

From: YOSHIFUJI Hideaki / 吉藤英明
Date: Thu Aug 09 2007 - 21:46:24 EST


Hello.

In article <m1zm108axi.fsf_-_@xxxxxxxxxxxxxxxxxxxxxxxxx> (at Thu, 09 Aug 2007 18:56:09 -0600), ebiederm@xxxxxxxxxxxx (Eric W. Biederman) says:

>
> - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary
> sysctl names for a function that works with proc.
>
> - In neighbour.c reorder the table to put the possibly unused entries
> at the end so we can remove them by terminating the table early.
>
> - In neighbour.c kill the entries with questionable binary sysctl
> handling behavior.
>
> - In neighbour.c if we don't have a strategy routine remove the
> binary path. So we don't the default sysctl strategy routine
> on data that is not ready for it.
>

I disagree. It is bad to remove existing interface.
Ditto for other patches.

Regards,

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/