Re: Are we properly prepared to handle 3 Socket setups?

From: Rene Herman
Date: Sat Aug 11 2007 - 23:40:30 EST


On 08/12/2007 05:29 AM, Roland Dreier wrote:

> /*
> * Maximum threshold is 125
> */
> threshold = min(125, threshold);
> > as either the comment or the code is wrong and it seems it's the
> code.

What's the problem? That line sets threshold to the smaller of the
current value or 125, which is exactly what one would want to do if
the maximum value is 125. Just do a couple of examples: eg if threshold
is 100 going into that line, then the value is left alone; if
threshold is 150 then it gets set to 125; and that seems exactly correct.

Crap, need bed, sorry (the fls/ilog2 things still stand -- quite possibly both not a problem either).

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/