Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

From: Jens Axboe
Date: Thu Aug 16 2007 - 03:03:17 EST


On Thu, Aug 16 2007, NeilBrown wrote:
>
> Almost every call to bio_data is for the first bio
> in a request. A future patch will add some accounting
> information to 'struct request' which will need to be
> used to find the start of the request in the bio.
> So replace bio_data with blk_rq_data which takes a 'struct request *'
>
> The one exception is in dm-emc were using
> page_address(bio->bi_io_vec[0].bv_page);
> is appropriate.

This (and 3+4) just look like preparatory patches if we want to merge
the full patchset, not bug fixes. I seem to recall you had more bug
fixes or cleanups in your patchset, maybe I was mistaken. So nak for now
for 2-4, I'd apply 5 but it depends on the previous.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/