Re: [PATCH] wait_task_zombie: don't fight with non-existing race with a dying ptracee

From: Roland McGrath
Date: Fri Aug 17 2007 - 16:04:59 EST


> (textually depends on wait_task_zombie-remove-unneeded-child-signal-check.patch)
>
> The "p->exit_signal == -1 && p->ptrace == 0" check and the comment are bogus.
> We already did exactly the same check in eligible_child(), we did not drop
> tasklist_lock since then, and both variables need write_lock(tasklist) to be
> changed.

I think this is correct. IIRC, when the check was added, ->ptrace could be
cleared some other way.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/