Re: [PATCH 0/4] Virtual Machine Time Accounting

[John Stoffel]

Laurent> The aim of these four patches is to introduce Virtual Machine
Laurent> time accounting.

So what does this buy us?  What increased functionality?  

Laurent> [PATCH 1/4] as recent CPUs introduce a third running state,
Laurent> after "user" and "system", we need a new field, "guest", in
Laurent> cpustat to store the time used by the CPU to run virtual
Laurent> CPU. Modify /proc/stat to display this new field.

What happens when you have multiple guests, is this state cummulative?  

I've glanced over these patches and the #ifdefs are ugly..., esp since
the overhead seems to exist even if you don't run any Guest CPUs.  Or
whatever you're doing here.

Please justify this patch more in terms of what it provides and why
it's a good thing to have.  

Thanks,
John
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/