Re: UNS: Re: [PATCH] kconfig: add *_silentdefconfig feature forconfig targets

[Roman Zippel]

Hi,

On Tue, 21 Aug 2007, Andres Salomon wrote:

> > I would really like to avoid another input mode.
> > I think it be better to implement this as a combination of "-s -D 
> > <default>" and the silent mode is adjusted to read another config instead 
> > of .config if defconfig_file is set.
> > 
> 
> As would I; however, that requires using getopt() (or equivalent).  I wasn't
> sure if there was some opposition to this..

I'm not sure how getopt() would change much (besides changing the "if" to 
a "while"), but I don't really mind either way.

> Of course, we'll still need some way from the makefile to call it.  I take
> it you're not opposed to 'make foo_silentdefconfig'?

No, that part looks fine.

> > >   - We seem to switch between using _() and not using it for strings; I'm
> > >     assuming that we don't actually care about i18n in conf.c, and that the
> > >     _() stuff was just copied from elsewhere.  If that's not the case, I
> > >     can update the patch to wrap strings properly.
> > 
> > I try to keep this uptodate, but I don't really check for this.
> > 
> 
> I'm not sure I follow; should I use _(), or no?

It means I don't really care much about it, but _() should be properly 
used where needed.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/