Re: [PATCH] RTC v3020 fixes

[Satyam Sharma]

Hi,


On Thu, 23 Aug 2007, Mike Rapoport wrote:

No changelog for patch ?!

> -	for ( i = 0; i < 4; i++ )
> +	for ( i = 0; i < 4; i++ ) {
>  		writel((address << (16-i)), EMV3020_VA_RTC);
> +		udelay(1);
> +	}
> +
> 

^ Spurious extra newline here.

> -	BCD_TO_BIN(dt->tm_mon);
> +	BCD_TO_BIN(dt->tm_mon - 1);

> -	emv3020_set_reg(0x06, dt->tm_mon);
> +	emv3020_set_reg(0x06, dt->tm_mon + 1);

Why? (looks unrelated to the udelay() fixes as well)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/