Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

From: Andrew Morton
Date: Tue Aug 28 2007 - 01:36:49 EST


On Tue, 28 Aug 2007 07:33:08 +0200 Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> > Again, ARRAY_SIZE() would be clearer here.
>
> No, this is only do this 16 times, no corresponding table :).

OK, poorly chosen example. But there are lots of others, like:

+
+ for (i = 0; i < 59; i++) {
+ stk11xx_read_dummy(dev, 0x02ff);
+ stk11xx_write_reg(dev, 0x02ff, 0x00);
+
+ stk11xx_write_reg(dev, 0x0204, values_204[i]);
+ stk11xx_write_reg(dev, 0x0205, values_205[i]);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/