Re: [PATCH] i386 and x86_64: randomize brk()

From: Andrew Morton
Date: Thu Aug 30 2007 - 21:06:12 EST


On Thu, 30 Aug 2007 17:10:03 +0200 (CEST) Jiri Kosina <jkosina@xxxxxxx> wrote:

> On Thu, 30 Aug 2007, Mike Frysinger wrote:
>
> > Blackfin too please :) i think v850 also falls into this category, but
> > i'm not terribly familiar with it ...
>
> Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK
> macro instead please?
>

Not strongly, but the general opinion seems to be that ARCH_HAS_FOO is
sucky. It should at least be done in Kconfig rather than in .h, but even
better is just to implement the thing for all architectures.

Please ask checkpatch.pl about you patch, too. It has commonly-occurring
coding mishaps.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/