Re: [RFC + PATCH] signalfd simplification

From: Oleg Nesterov
Date: Sun Sep 02 2007 - 08:59:22 EST


On 09/02, Oleg Nesterov wrote:
>
> Small problem: unless I missed something, signalfd_deliver() and sys_signalfd()
> should use wake_up_all(), not wake_up() which implies nr_exclusive == 1.
>
> It is possible that we have multiple threads waiting on ->signalfd_wqh with
> the the different ->sigmask. In this case, the first woken thread can ignore
> the signal, we should wake up all of them.

Oops, sorry for noise. I forgot about WQ_FLAG_EXCLUSIVE, we don't set it by
default.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/