Re: [PATCH] x86/x86-64 PCI domain support

[Jeff Garzik]

Randy Dunlap wrote:
> On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote:
>
> > Andi Kleen wrote:
> > > > > The second function is redundant? 
> > > > No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled.
> > > Then the other function is redundant.
> > No, both functions are required by the interface.
>
> by what interface?  and why, please?  (instead of just stating "required")

grep for CONFIG_PCI_DOMAINS in arch code and include/linux/pci.h.

This is normal "arch" interface:  you enable a define, and a group of 
functions is assumed to be present.  Otherwise (!defined), a set of stub 
no-ops is activated for your arch.

I have implemented the [small] group of functions the code assumes to be 
present, when CONFIG_PCI_DOMAINS is enabled, like all the other arches 
that implement PCI domain support.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/