Re: [patch 1/6] Linux Kernel Markers - Architecture IndependentCode

From: Randy Dunlap
Date: Thu Sep 06 2007 - 19:38:25 EST


On Thu, 6 Sep 2007 16:04:29 -0700 Andrew Morton wrote:

> > On Thu, 6 Sep 2007 16:00:01 -0700 Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > On Thu, 06 Sep 2007 16:07:34 -0400 Mathieu Desnoyers wrote:
> >
> > > Changelog:
> > > - markers_mutex now nests inside module_mutex rather than the opposite.
> > >
> > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
> > > Reviewed-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> > > Reviewed-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > > Reviewed-by: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
> >
> > Documentation/SubmittingPatches recognizes Signed-off-by: and
> > Acked-by:. Nothing about Reviewed-by. Quote:
> >
> > Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
> > has at least reviewed the patch and has indicated acceptance.
> >
> > Reviewed-by: carries no such connotation or indication IMO.
> > Please use Acked-by if that's what these reviewers have done.
>
> Yeah. We will start introducing Reviewed-by: (I haven't yet quite worked
> out how yet) but it will be a quite formal thing and it would be something
> which the reviewer explicitly provided. For now, let's please stick with
> acked-by (if those individuals did indeed send an acked-by)
> -

Thanks. I look forward to the explanation of Reviewed-by, what it
means, and how it differs from Acked-by.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/