RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

From: Zhang Wei-r63237
Date: Tue Sep 11 2007 - 06:11:35 EST


>
> If this is experimental, perhaps you should mark the depends line as
> such
> depends on on DMA_ENGINE && PPC && EXPERIMENTAL

I'll add EXPERIMENTAL for MPC83xx only.

>
> [...]
>
> >+
> >+ fsl_dma_memcpy_issue_pending(chan);
> >+ while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
> >+ != DMA_SUCCESS);
>
> Again, is it possible to hang your thread here?
>
> [...]

I'll add msleep here.

Thanks!

- zw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/