Re: [PATCH -mm] uvesafb: Don't access VGA registers directly when running on non-x86

From: Paul Mundt
Date: Tue Sep 11 2007 - 20:44:58 EST


On Wed, Sep 12, 2007 at 01:09:59AM +0200, Michal Januszewski wrote:
> The VGA registers are only available at their legacy IO locations on x86.
> Don't try to access them when running on other arches.
>
> Note that the code accessing them directly is just an optimization (limits
> slow BIOS function calls). We don't lose any functionality by using
> BIOS calls instead of it on non-x86.
>
If you do that, then you also have to #ifdef CONFIG_X86 around
video/vga.h, as that drags in asm/vga.h, which does not exist on all
platforms. I have little interest in adding a stub vga.h on my
architectures to support a driver that in practice works on nothing but
x86.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/